Skip to content

module,win: fix long subpath import#62101

Open
StefanStojanovic wants to merge 2 commits intonodejs:mainfrom
JaneaSystems:mefi-import-fix
Open

module,win: fix long subpath import#62101
StefanStojanovic wants to merge 2 commits intonodejs:mainfrom
JaneaSystems:mefi-import-fix

Conversation

@StefanStojanovic
Copy link
Contributor

This change fixes the linked issue and adds a regression test.

Fixes: #62043

@StefanStojanovic StefanStojanovic added module Issues and PRs related to the module subsystem. windows Issues and PRs related to the Windows platform. labels Mar 4, 2026
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.74%. Comparing base (330e3ee) to head (c2c11eb).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62101      +/-   ##
==========================================
- Coverage   91.62%   88.74%   -2.89%     
==========================================
  Files         337      676     +339     
  Lines      140453   206553   +66100     
  Branches    21801    39459   +17658     
==========================================
+ Hits       128694   183303   +54609     
- Misses      11536    15310    +3774     
- Partials      223     7940    +7717     
Files with missing lines Coverage Δ
src/node_modules.cc 80.14% <100.00%> (ø)

... and 490 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subpath imports (#) fail on Windows when package.json path >= 260 chars (MAX_PATH)

3 participants